Send explosions only to nearby players#82
Send explosions only to nearby players#82TheMeinerLP merged 5 commits intoOneLiteFeatherNET:masterfrom
Conversation
|
Can you try to re-implement also a test for that behaviour ? |
That would be beneficial to do so, I would also welcome that if @joelramilison wants to add this |
The problem is, we can't approve it because the pipelines fails |
|
What would a unit test for that look like, what are you thinking of? I'm asking because the code changes were quite minimal, the getNearbyEntities function is already being tested and the rest seems quite straightforward. |
|
Regardless of whether the change is small, testing allows us to ensure that the quality remains the same in version updates. In addition, we can ensure that nothing breaks in the event of changes to other areas that may only have an indirect effect. |
src/test/java/net/minestom/server/instance/ExplosionIntegrationTest.java
Show resolved
Hide resolved
src/test/java/net/minestom/server/instance/ExplosionIntegrationTest.java
Show resolved
Hide resolved
src/test/java/net/minestom/server/instance/ExplosionIntegrationTest.java
Outdated
Show resolved
Hide resolved
|
Can you resolve the merge conflicts ? |
|
We need to test the tests manually before we merge |
|
|
Proposed changes
Explosion packets are now only sent to nearby players to improve performance.
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
Fixes issue #64